Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewing TRestDetectorHitsSmearingProcess #72

Merged
merged 6 commits into from
Mar 7, 2023
Merged

Reviewing TRestDetectorHitsSmearingProcess #72

merged 6 commits into from
Mar 7, 2023

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Mar 2, 2023 •
edited by pull-request-badge bot
Loading

jgalan Medium: 133

  • Adding documentation and official headers
  • Improved the way the seeds are handled
  • Cleaning up a bit. Removing unnecessary InitFromConfigFile method re-implementation.
  • Updated PR badge so that it shows the GitHub pipeline at the PR description.

@jgalan jgalan mentioned this pull request Mar 3, 2023
Merged
@jgalan jgalan requested a review from a team March 3, 2023 10:11
@jgalan jgalan marked this pull request as ready for review March 3, 2023 10:11
@jgalan jgalan merged commit 6845aa7 into master Mar 7, 2023
@jgalan jgalan deleted the jgalan_smear_review2 branch March 7, 2023 10:00
@jgalan jgalan mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanangp juanangp juanangp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgalan @juanangp