Adding new basic topological hit transformations #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgalan
changed the title
cmargalejo
reviewed
Jul 19, 2023
cmargalejo
reviewed
Jul 19, 2023
Co-authored-by: Cristina Margalejo <77193103+cmargalejo@users.noreply.github.com>
Co-authored-by: Cristina Margalejo <77193103+cmargalejo@users.noreply.github.com>
…ed to legacy library
cmargalejo
approved these changes
Jul 24, 2023
…n_hits_rotation * origin/jgalan_hits_rotation: TRestDetectorHitmap fixing typos
lobis
reviewed
Aug 29, 2023
| fInputEvent = (TRestDetectorHitsEvent*)inputEvent; | ||
| fOutputEvent->SetEventInfo(fInputEvent); | ||
|
|
||
| Bool_t xyzEvent = fInputEvent->GetXYZHits()->GetNumberOfHits() != 0; |
There was a problem hiding this comment.
I am not sure I understand this @jgalan but should this condition be checked for each hit and if is not met, not rotate the hit?
DavidDiezIb
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipeline/hitsalthough not integrated into the GitHub pipeline.Specular tests
Rotation tests
Translation tests
