Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend 'fem *' command before 'clr tstamp' and 'clr evcnt' in command files #14

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

AlvaroEzq
Copy link
Contributor

@AlvaroEzq AlvaroEzq commented Sep 30, 2024

Trying to solve issue #11.

This is the simpliest solution in terms of coding. There should be a better solution, but it would requiere a deeper understanding of the mclient source code which I lack of.

@AlvaroEzq AlvaroEzq linked an issue Sep 30, 2024 that may be closed by this pull request
@AlvaroEzq AlvaroEzq marked this pull request as ready for review October 3, 2024 14:37
@AlvaroEzq AlvaroEzq requested a review from lobis as a code owner October 3, 2024 14:37
@lobis lobis force-pushed the 11-mclient-bug-when-executing-command-file branch from e58f5c4 to eeb19c3 Compare October 16, 2024 10:22
Copy link
Member

@lobis lobis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes may have unforseen consequences in the future, but it's easy to backtrack if this is the case, so I will approve.

@AlvaroEzq feel free to merge this PR whenever you want to if you don't have any further comments.

This PR will close #11.

@AlvaroEzq AlvaroEzq merged commit 806c14c into main Oct 19, 2024
2 checks passed
@AlvaroEzq AlvaroEzq deleted the 11-mclient-bug-when-executing-command-file branch October 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mclient bug when executing command file
2 participants