TRestEventRateAnalysisProcess: auto adjust under single/multi thread condition #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vindaar
reviewed
Mar 28, 2022
Vindaar
reviewed
Mar 28, 2022
source/framework/analysis/src/TRestEventRateAnalysisProcess.cxx
Outdated
Show resolved
Hide resolved
jgalan
approved these changes
Mar 29, 2022
|
What about this PR? Should be approved or closed? |
still waiting for approval |
Vindaar
reviewed
Jul 29, 2022
Comment on lines
+58
to
+63
| if (fRateAnalysis) { | ||
| RESTMetadata << "Rate analysis is on under single thread mode" << RESTendl; | ||
| } | ||
| else { | ||
| RESTMetadata << "Rate analysis is off due to multi-thread" << RESTendl; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (fRateAnalysis) { | |
| RESTMetadata << "Rate analysis is on under single thread mode" << RESTendl; | |
| } | |
| else { | |
| RESTMetadata << "Rate analysis is off due to multi-thread" << RESTendl; | |
| } | |
| if (fRateAnalysis) { | |
| RESTMetadata << "Rate analysis is on under single thread mode" << RESTendl; | |
| } | |
| else { | |
| RESTMetadata << "Rate analysis is off due to multi-thread" << RESTendl; | |
| } |
Vindaar
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The observable
SecondsFromStartandHoursFromStartinTRestEventRateAnalysisProcessare not single thread observables. We can preserve multi-thread run forTRestEventRateAnalysisProcessif we don't need the rate observables.So this PR changes: if
TRestEventRateAnalysisProcessdetects that it is being running under multi-thread, it will turn off the observableEventTimeDelayandMeanRate_InHzautomatically.