-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pattern mask classes #198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be extracted at the end of the filename
juanangp
reviewed
May 27, 2022
lobis
approved these changes
May 27, 2022
juanangp
reviewed
May 27, 2022
juanangp
reviewed
May 27, 2022
juanangp
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an abstract metadata class
TRestPatternMask
that encapsulates the implementation of masks (or filters) that define a pattern. The abstract class implements a virtual methodGetRegion
that must be implemented at the inherited class with the logic for each type of mask. This method must return an integer identifying the region where the particle was hit.TRestPatternMask
implements a common method to test the maskDrawMonteCarlo
, generating a canvas with the result.TRestPatternMask
implements rotation, pattern shift, and pattern limits (circular mask), those can be applied at eachGetRegion
method by using the methodApplyCommonMaskTransformation
.Four types of mask have been implemented at this PR. Stripped, Grid, Rings, Spider.