Simplified some of TRestTools methods using <filesystem> and avoid usage of env variables
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D env variable won't cause problems
…`TRestTools::ReturnToPreviousDirectory` and replaced its single usage in `restG4` with simpler logic (without env variables!)
…d avoid returning seg fault, added informative error messages
juanangp
approved these changes
May 26, 2022
DavidDiezIb
approved these changes
May 26, 2022
jgalan
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before C++17 we had to do some complicated logic to work with paths, this is solved with the ` header, now present at REST.
Some methods to work with paths in REST relied on environment variables to work, such as
PWD. This was causing some unexpected issues on my dev environment when thePWDenv variable doesn't match the current working directory.I have removed all apperances of environment variables when working on paths and I have rewritten the old methods to use
<filesystem>. Now these methods are a single line and could probably be removed altogether so people start using the filesystem library, but they remain for now.I removed the method
TRestTools::ReturnToPreviousDirectoryas it relied on environment variables for state management and it was only used once in the whole code base. I replaced its usage in restG4.Related PR: