-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gauss hit zeroes fit #254
Gauss hit zeroes fit #254
Conversation
Hi @cmargalejo , the problem with the pipeline is surely related to the fact that your branch is not updated with master. You should do locally:
So that this PR gets updated |
…work into gaussHitZeroesFit
@@ -545,103 +546,183 @@ void TRestHits::GetBoundaries(std::vector<double>& dist, double& max, double& mi | |||
Double_t TRestHits::GetGaussSigmaX() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a description to this method. Perhaps reusing some text from the PR description. I see this class is not following the standard headers. I will just quickly updated that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description added in 154df75
What it happens if you set the new hits on the sides to equal zero? If you add the new hits, then the energy of the event will be affected, or the hits are added just for the gaussian fit, then removed for further processing? |
Perhaps it would be interesting to add the image you attached to the PR description to the documentation. |
Yes, the hits are only added to a TGraph to perform the fit, so they don't go into any further processing. Still, their energy is 0. |
This pull request aims to solve some issues that were found with the observables GaussSigmaX, GaussSigmaY and GaussSigmaZ, which are computed by fitting a gaussian to each event.
Some of the events were found to have sigmas that were too large. After a deep study, the hypothesis is that the fit fails especially for small events that have too few hits. Not seeing a hit doens't necesarily mean there is no energy on that channel, but that it is below the threshold. Thus, the proposed solution is to add one hit to the left and one hit to the right, at a value 0+/-error.
The main changes are:
-Adding two hits to each hits event.
-Define the energy of these hits as 0 +/- 70 ADC. This error is defined based on typical for the micromegas detectors.
To illustrate the changes, the image below shows the same event before the changes in the code in the left, and the new fit in the right.