-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates #263
Merged
Merged
Minor updates #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanangp
reviewed
Jul 11, 2022
juanangp
approved these changes
Jul 11, 2022
jgalan
approved these changes
Jul 11, 2022
jgalan
approved these changes
Jul 11, 2022
This was referenced Jul 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I introduce small changes motivated by other PRs.
std::filesystem::weakly_canonical
to save the output file path insideTRestRun
after "forming". Saving the path as a canonical absolute path helps solve a bug showing the wrong path at the end of simulation when launching from the IDE. Currently paths are being stored with things such as "./", these things are now resolved before storing and the path is absolute.TRestHits
no longer inherits fromTObject
as this is not necessary unless we want to store the hits directly in the root file, but we always save the class containing the hits, such as aTRestEvent
. This reduces the members of the class which reduces the visual clutter when using the root explorer. AlsoTRestHits::RemoveHits
is now virtual so it can be overriden in other classes.TRestHits
such asfNHits
have been made protected instead of public and should be accessed by the corresponding getter which already existed before this PR.Related PR: