Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "use [[(]]) instead of <<(>>) for analysis plots to correct invalid xml syntax" #368

Closed
wants to merge 1 commit into from

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Feb 9, 2023

jgalan Ok: 81

Reverts #362

This PR broke the rawlib pipeline as we can see at the following PR.

rest-for-physics/rawlib#95

@juanangp it would be easy to introduce key validation pipelines into the framework pipeline?

@jgalan jgalan requested a review from lobis February 9, 2023 11:39
@lobis
Copy link
Member

lobis commented Feb 9, 2023

I guess this PR is just for testing right? we do not want to revert this change.

@jgalan jgalan requested a review from juanangp February 9, 2023 12:14
@juanangp
Copy link
Member

juanangp commented Feb 9, 2023

I guess this PR is just for testing right? we do not want to revert this change.

Indeed, I think it would be better to identify the issue, I guess should be inside some config file.

@juanangp
Copy link
Member

juanangp commented Feb 9, 2023

@juanangp it would be easy to introduce key validation pipelines into the framework pipeline?

I think it is possible, but it is not straightforward. I can have a look to it.

@jgalan
Copy link
Member Author

jgalan commented Feb 9, 2023

Indeed, I think it would be better to identify the issue, I guess should be inside some config file.

Ok, I think this should solve the issue

#370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants