Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when drawing signals #75

Merged
merged 5 commits into from
Sep 3, 2022
Merged

Fixed bug when drawing signals #75

merged 5 commits into from
Sep 3, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Sep 1, 2022

lobis Medium: 125

Before this change some TRestRawSignalEvent gave error when being drawn if the signals were not above 0 (they can be negative since we are using Short_t as the data type).

I also did a minor update on the drawing of signals so that the x axis fits the full range instead of having some part empty.

@lobis lobis requested review from jgalan and juanangp September 1, 2022 12:05
@lobis lobis added the bug Something isn't working label Sep 1, 2022
@lobis lobis requested a review from DavidDiezIb September 1, 2022 12:17
@lobis lobis marked this pull request as ready for review September 1, 2022 16:09
@lobis
Copy link
Member Author

lobis commented Sep 2, 2022

Can we merge this PR @jgalan @juanangp even though its not passing the pipeline due to #74? or should we wait until that is fixed?

@lobis lobis merged commit 220ea98 into master Sep 3, 2022
@lobis lobis deleted the lobis-event branch September 3, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants