Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New structure for TRestTrackAnalysisProcess #41

Closed
4 tasks done
DavidDiezIb opened this issue Mar 1, 2024 · 4 comments
Closed
4 tasks done

New structure for TRestTrackAnalysisProcess #41

DavidDiezIb opened this issue Mar 1, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@DavidDiezIb
Copy link
Member

DavidDiezIb commented Mar 1, 2024

TRestTrackAnalysisProcess is huge and it has too many observables to maintain (76). The idea is to split this process according to the type of track (XYZ or XZ-YZ) keeping all observables but segmented into several processes. Also naming convention will be homogenised.

  • TRestTrack3DAnalysisProcess -> For XYZ tracks. In case XZ-YZ tracks are provided, they will be merged.
  • TRestTrack2DAnalysisProcess -> For XZ-YZ tracks
  • TRestTrackBasicAnalysisProcess -> Most elemental observables taking into account all tracks
  • Max track and second max track analysis. Could be inside previous processes or in dedicated ones (I tend to prefer the second option)
@DavidDiezIb
Copy link
Member Author

DavidDiezIb commented Mar 7, 2024

TRestTrack2DAnalysisProcess implemented. Only for XZ-YZ tracks, also Max Track and Second Max Track observables added.
So, probably the four processes proposed at the beginning will be reduced to two: TRestTrack2DAnalysisProcess and TRestTrack3DAnalysisProcess. Basic observables for TrackEvent will be generated in both processes, also Max and Second Max Track observables.

@DavidDiezIb
Copy link
Member Author

DavidDiezIb commented Mar 10, 2024

TRestTrack3DAnalysisProcess implented here: #43
Only for pure XYZ tracks, merging of XZ-YZ tracks not considered.

@DavidDiezIb
Copy link
Member Author

Finally two dedicated processes for different types of tracks, with all basic and more elaborated observables. Not merging in 3D analysis. Only slightly merging in 2D analysis for some observables (balance observables, for example, that combine data from XZ and YZ tracks)

@DavidDiezIb
Copy link
Member Author

I'll close the Issue as the main objectives have been fulfilled. Fill free to reopen if you find any bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants