-
Notifications
You must be signed in to change notification settings - Fork 8
Use scarf links for all the things (for 1.2.0 only!) #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying documentation with
|
Latest commit: |
bc5e806
|
Status: | ✅ Deploy successful! |
Preview URL: | https://514f2e81.documentation-beg.pages.dev |
Branch Preview URL: | https://scarf-links-1-2-0.documentation-beg.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We will also need to replace this in the get restate page: https://restate.dev/get-restate/
cdf1676
to
650da74
Compare
@pcholakov for the restatectl changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better to keep restatectl
out of sight for the most part, thank you @jackkleeman!
@jackkleeman shall we merge this PR now? |
650da74
to
1729553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the download links @jackkleeman. The changes look good to me. I left a single question about the compatibility of docker.restate.dev
with podman. Maybe @slinkydeveloper you can help here.
The server and CLI images both contain the `restatectl` tool. To run `restatectl`, use the following command: | ||
|
||
```shell | ||
docker run -it --network=host --entrypoint restatectl docker.restate.dev/restatedev/restate-cli:VAR::RESTATE_VERSION nodes ls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slinkydeveloper do we need some extra documentation to make docker.restate.dev
work with podman?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still doesn't work for me
!10208 ➜ podman pull docker.restate.dev/restatedev/restate ~
Trying to pull docker.restate.dev/restatedev/restate:latest...
Error: initializing source docker://docker.restate.dev/restatedev/restate:latest: reading manifest latest in docker.restate.dev/restatedev/restate: manifest unknown
!10208 ➜ podman pull docker.restate.dev/restatedev/restate:latest ~
Trying to pull docker.restate.dev/restatedev/restate:latest...
Error: initializing source docker://docker.restate.dev/restatedev/restate:latest: reading manifest latest in docker.restate.dev/restatedev/restate: manifest unknown
!10209 ➜ podman pull docker.restate.dev/restatedev/restate:1.2 ~
Trying to pull docker.restate.dev/restatedev/restate:1.2...
Error: initializing source docker://docker.restate.dev/restatedev/restate:1.2: reading manifest 1.2 in docker.restate.dev/restatedev/restate: manifest unknown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some configuration missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slinkydeveloper forking this problem off from this PR to unblock the release of the documentation. If there is some configuration missing, it would be great if you could create a PR to add it to our documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some configuration missing?
Not that I'm aware of, it just looks like something doesn't work in the interplay between scarf proxy and podman.
7aefe49
to
bc5e806
Compare
Should only be merged for 1.2.0, as the https://restate.gateway.scarf.sh/latest/ type links won't work until the 'latest' release has artifacts in the new format (restate-server and restate-cli), and currently latest is 1.1.6 as prereleases do not count.