Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify restate.Service and restate.Object into restate.Reflect #27

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

jackkleeman
Copy link
Contributor

These names pollute the namespace a bit and they have similar signatures anyway. Reflect is more descriptive of what they do.

These names pollute the namespace a bit and they have similar signatures
anyway. Reflect is more descriptive of what they do.
Copy link

Test Results

  5 files  ±0    5 suites  ±0   7m 49s ⏱️ +14s
 41 tests ±0   41 ✅ ±0  0 💤 ±0  0 ❌ ±0 
101 runs  ±0  101 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c301e04. ± Comparison against base commit 7e3afc4.

Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jackkleeman jackkleeman merged commit b816ace into main Aug 14, 2024
3 checks passed
@jackkleeman jackkleeman deleted the reflect2 branch August 14, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants