Use panics for serialisation errors #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
force-pushed
the
codec-panic
branch
from
084a8b8 to
d6322af
Compare
slinkydeveloper
approved these changes
Aug 21, 2024
Contributor
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
LGTM, this definitely improves the code!
context.go
Outdated
Comment on lines
170
to
171
| // If the invocation was cancelled while obtaining the state (only possible if eager state is disabled), | ||
| // a cancellation error is returned. If eager state is enabled (the default), err will always be ErrKeyNotFound or nil. |
Contributor
There was a problem hiding this comment.
Because this is a runtime config, and not SDK, i wouldn't personally build code against such assumption that eager state is enabled or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to simplify apis quite a bit, much less errors all over the place