Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move headers and delays into requestoption/ send option #34

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

jackkleeman
Copy link
Contributor

But keep codec as a property of the client, as this is a per method option and you might want to store a client and use it repeatedly with the codec set.

Copy link

github-actions bot commented Aug 20, 2024

Test Results

  5 files  ±0    5 suites  ±0   2m 20s ⏱️ +7s
 41 tests ±0   41 ✅ ±0  0 💤 ±0  0 ❌ ±0 
101 runs  ±0  101 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 94e4020. ± Comparison against base commit 16fb256.

♻️ This comment has been updated with latest results.

But keep codec as a property of the client, as this is a per method
option and you might want to store a client and use it repeatedly with
the codec set.
Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing!

@jackkleeman jackkleeman merged commit eb778c7 into main Aug 21, 2024
3 checks passed
@jackkleeman jackkleeman deleted the client-api branch August 21, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants