Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use panics where possible, implement selector #4

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Use panics where possible, implement selector #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
197f87e
Journal mismatch via panics
jackkleeman Jul 11, 2024
628dc8f
Failed writes should also panic
jackkleeman Jul 11, 2024
271a955
Creating journal entries should panic, not return error
jackkleeman Jul 11, 2024
1da28e5
Make replayOrNew infallible except by panic
jackkleeman Jul 11, 2024
7e49dcf
Implement suspension
jackkleeman Jul 11, 2024
fe268ee
Implement selector
jackkleeman Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion example/ticket_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ func unreserve(ctx restate.ObjectContext, _ restate.Void) (void restate.Void, er
}

if status != TicketSold {
return void, ctx.Clear("status")
ctx.Clear("status")
return void, nil
}

return void, nil
Expand Down
3 changes: 2 additions & 1 deletion example/user_session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ func checkout(ctx restate.ObjectContext, _ restate.Void) (bool, error) {
}
}

return true, ctx.Clear("tickets")
ctx.Clear("tickets")
return true, nil
}

var (
Expand Down
180 changes: 180 additions & 0 deletions generated/proto/go/go.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

186 changes: 0 additions & 186 deletions generated/proto/javascript/javascript.pb.go
View file
Open in desktop

This file was deleted.

Loading
Loading