Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workflows and durable promises #40

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Implement workflows and durable promises #40

merged 8 commits into from
Nov 7, 2024

Conversation

jackkleeman
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Sep 23, 2024

Test Results

  5 files  +  5    5 suites  +5   2m 0s ⏱️ + 2m 0s
 42 tests + 42   42 ✅ + 42  0 💤 ±0  0 ❌ ±0 
104 runs  +104  104 ✅ +104  0 💤 ±0  0 ❌ ±0 

Results for commit 2733774. ± Comparison against base commit da87f6a.

♻️ This comment has been updated with latest results.

@jackkleeman jackkleeman force-pushed the workflows branch 2 times, most recently from 3d71e32 to ab5b80a Compare September 23, 2024 11:48
@jackkleeman jackkleeman changed the title Implement workflows Implement workflows and durable promises Sep 23, 2024
@arun0009
Copy link

arun0009 commented Nov 7, 2024

are workflows missing in go sdk until this PR is merged?

@jackkleeman
Copy link
Contributor Author

yes, but its going to be merged today or tomorrow

Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left some minor comments. At some point I think you should update the test tool to last version (or 2.1, which is before distributed runtime)

facilitators.go Outdated Show resolved Hide resolved
facilitators.go Outdated Show resolved Hide resolved
handler.go Outdated Show resolved Hide resolved
handler.go Outdated Show resolved Hide resolved
"github.com/restatedev/sdk-go/internal/wire"
)

func (c *Context) Promise(key string, opts ...options.PromiseOption) DecodingPromise {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't use type assertions?

router.go Outdated Show resolved Hide resolved
}

// NewWorkflow creates a new named Workflow
func NewWorkflow(name string, opts ...options.ServiceDefinitionOption) *workflow {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way you can build this API (if you would like) is to take the workflow run method as parameter of the builder factory method here, and then let handler really accept only shared handlers.

jackkleeman and others added 6 commits November 7, 2024 15:48
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
@jackkleeman jackkleeman merged commit d8408da into main Nov 7, 2024
3 checks passed
@jackkleeman jackkleeman deleted the workflows branch November 7, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants