-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement workflows and durable promises #40
Conversation
3d71e32
to
ab5b80a
Compare
ab5b80a
to
e1438df
Compare
are workflows missing in go sdk until this PR is merged? |
yes, but its going to be merged today or tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left some minor comments. At some point I think you should update the test tool to last version (or 2.1, which is before distributed runtime)
"github.com/restatedev/sdk-go/internal/wire" | ||
) | ||
|
||
func (c *Context) Promise(key string, opts ...options.PromiseOption) DecodingPromise { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't use type assertions?
} | ||
|
||
// NewWorkflow creates a new named Workflow | ||
func NewWorkflow(name string, opts ...options.ServiceDefinitionOption) *workflow { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way you can build this API (if you would like) is to take the workflow run method as parameter of the builder factory method here, and then let handler really accept only shared handlers.
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
No description provided.