Feature/general serde #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce GeneralSerde to handle both Pydantic BaseModel instances and regular JSON objects. - Use model_dump_json for Pydantic models, falling back to json.dumps for non-Pydantic objects. - Maintain consistency with existing serde implementations.
…_hints for clarity
igalshilman
reviewed
Mar 14, 2025
Contributor
igalshilman
left a comment
igalshilman
left a comment
There was a problem hiding this comment.
Hey @ouatu-ro,
great stuff!
I've left few comments for you to address, after that really looks good to me to merge!
… up GeneralSerde logging
- Updated imports and default serializer/deserializer in **context**, handler, object, **server_context**, service, and workflow modules. - DefaultSerde provides a unified approach for JSON serialization/deserialization, ensuring compatibility with both Pydantic models and standard JSON objects.
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
Contributor
Author
|
Renamed |
igalshilman
approved these changes
Mar 18, 2025
Contributor
igalshilman
left a comment
igalshilman
left a comment
There was a problem hiding this comment.
Amazing, looks good to me!
igalshilman
approved these changes
Mar 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a general serde that can handle serialisation for both Pydantic objects and regular JSON objects. Tested for workflows, services and virtual objects.
Related to #45