Try to auto deduce the types provided for ctx.run() #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit try to deduce the type that is provided to the ctx.run(), in the case where a `serde` parameter is not passed. If type hints are there we will deduce the correct serializer from the type hints. If the type hints are not there, we will consult the `type_hint` parameter and try to deduce a serializer from there. If nothing worked, we will default to the DefaultSerde()
igalshilman
force-pushed
the
autodetect_run_type
branch
from
c61b4c5 to
08bd523
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit try to deduce the type that is provided to the ctx.run(), in the case where a
serdeparameter is not passed. If type hints are there we will deduce the correct serializer from the type hints. If the type hints are not there, we will consult thetype_hintparameter and try to deduce a serializer from there. If nothing worked, we will default to the DefaultSerde()