Skip to content

Improve CombineablePromise types #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Improve CombineablePromise types #530

merged 1 commit into from
Apr 23, 2025

Conversation

nikrooz
Copy link
Contributor

@nikrooz nikrooz commented Apr 23, 2025

Before:
Screenshot 2025-04-23 at 10 36 50

After:
Screenshot 2025-04-23 at 10 42 33

@nikrooz
add const to combinablepromise types
9790437 
Signed-off-by: Nik Nasr <nik@restate.dev>
@nikrooz nikrooz requested a review from igalshilman April 23, 2025 09:51
@github-actions GitHub Actions
Copy link

Test Results

  7 files  ±0    7 suites  ±0   3m 34s ⏱️ -32s
 54 tests ±0   53 ✅ ±0  1 💤 ±0  0 ❌ ±0 
223 runs  ±0  220 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 9790437. ± Comparison against base commit 03bf4e2.

igalshilman
igalshilman approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@nikrooz nikrooz merged commit 29dc906 into main Apr 23, 2025
3 checks passed
@nikrooz nikrooz deleted the NN_fix-combinablepromise-type branch April 23, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikrooz @igalshilman