Fix tests #533
Merged
Fix tests #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nik Nasr <nik@restate.dev>
nikrooz
commented
Apr 30, 2025
| @@ -41,8 +41,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "tsx": "^4.15.7", | |||
| "@restatedev/restate-sdk-testcontainers": "^1.5.4", | |||
| "testcontainers": "^10.24.1" | |||
There was a problem hiding this comment.
When GenericContainer was imported from two separate modules (restate-sdk-examples and restate-sdk-testcontainers), it created two distinct versions of the class—causing issues with testcontainers. To resolve this, I introduced RestateGenericContainer as a single, unified reference.
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
nikrooz
commented
Apr 30, 2025
Comment on lines
33
to
34
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access,@typescript-eslint/no-unsafe-assignment,@typescript-eslint/no-unsafe-assignment | ||
| const handler = greeterFoo["service"]["greet"]; | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-call | ||
| expect(await handler({}, "abc")).toEqual("abc"); | ||
| // @ts-ignore | ||
| expect(await greeterFoo.service.greet({}, "abc")).toEqual("abc"); |
There was a problem hiding this comment.
The value of this depends how a function is called rather than how it was created :)
extracting the method and calling it directly makes this undefined.
| @@ -167,6 +167,11 @@ export class RestateTestEnvironment { | |||
| export type TypedState = Record<string, any>; | |||
| export type UntypedState = { _: never }; | |||
|
|
|||
| export class RestateGenericContainer extends GenericContainer { | |||
There was a problem hiding this comment.
My understanding here is that you can't get away without adding a new public API?
If not, then name this RestateContainer
There was a problem hiding this comment.
unfortunately not. done ✅
Signed-off-by: Nik Nasr <nik@restate.dev>
slinkydeveloper
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.