Validate sleep duration is non-negative. #537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
At the moment a negative sleep duration causes the service to crash with this error
After:
One downside of this approach is that we will not have a SLEEP COMMAND entry in the journal. Since the duration of sleep is recorded as part of an immutable SLEEP entry, I am not sure what's the best way to commit the entry while keeping the error recoverable (ie. changing the duration).