-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for remote ip/address without requiring HttpServletRequest #2176
Add support for remote ip/address without requiring HttpServletRequest #2176
Conversation
Hah, saw an SSE test fail, but this is not due to my changes this time. That makes me think that perhaps it wasn't my changes which were guilty in the async io branch… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FroMage . To answer your questions, I would actually prefer telling the users to inject HttpRequest
and get rid of ResteasyRequest
, if possible. Users already inject HttpRequest
for few other scenarios.
I'm fine with getRemoteAddress()
and getRemoteHost()
.
OK, thanks for the feedback. I will udpate the PR. |
Thanks! |
837cad6
to
b3f1122
Compare
Done. |
|
Huh, @asoldano I merged it because I thought you had accepted the PR, but now I checked and it's not clear. Is it alright or did I mess up? |
@FroMage no problem for having merged it, I would have done that anyway (just haven't had time yesterday). The only caveat for next time would be that we require all commits to have a reference to the relevant jira, which in this case is missing (btw, if the original commit message does not have the reference, a trick is to add it merging the PR with "Squash and merge" as that allows editing the message) |
New interface ResteasyRequest extends JAX-RS Request with those methods
But it delegates to HttpRequest (perhaps we don't need both?)
This works, but we need to make some decisions:
ResteasyRequest
as a subtype of JAX-RSRequest
, or do we tell users to inject RESTEasy'sHttpRequest
which has to have those methods anyway?String getRemoteAddress/getRemoteHost
duo or go for something likeInetSocketAddress getRemoteAddress
like Netty has?WDYT @patriot1burke @asoldano ?