Add support for returning custom response headers from a list service #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st service request
bbellsct
changed the title
|
I merged master into my list-response-headers branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to return some metadata about the response of a list service request in the response headers, much in the same way that totalCount and other paging parameters are returned. We've modified the RestfulApiController to check if an httpResponseHeaders property exists on the object returned by the list. If that property exists and is a map, we generate the response headers directly from that map. For simplicity, we incorporated an optional responseHeaders as part of the PagedResultArrayList object in which to pass the map to the controller. This branch is based off the 0.8.0 tag as that is the version of the restful-api currently in use by our project.