Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshots sorted by timestamp in restic find #4409

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

arjunajesh
Copy link
Contributor

@arjunajesh arjunajesh commented Jul 16, 2023

What does this PR change? What problem does it solve?

Restic find printed snapshots in an arbitrary order. Now restic prints the snapshots sorted by timestamp.

Was the change previously discussed in an issue or on the forum?

Closes #1495

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've tweaked the changelog a bit and rebased the PR.

As reported by the CI in https://github.com/restic/restic/actions/runs/5569139004/job/15080452233?pr=4409 only a fixed set of entry types is allowed:

file changelog/unreleased/issue-1495: entry type "Feature" is invalid, valid types: map[Bugfix:2 Change:3 Enhancement:4 Security:1]

@MichaelEischer MichaelEischer added this pull request to the merge queue Jul 23, 2023
Merged via the queue into restic:master with commit 1fe1ec4 Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort Output of "restic find" by snapshot date
2 participants