Ianvonholt 5.x

[retrohacker]

Pre-Submission Checklist

• Opened an issue discussing these changes before opening the PR
• Ran the linter and tests via make prepush
• Included comprehensive and convincing tests for changes

Issues

Closes:

• Issue Fix for #1407 #1408
• Issue Restify 5.0 Response.js - Maximum call stack size exceeded - Node 8.1.4 #1407

Summarize the issues that discussed these changes

Fully fix for Node.js v7 and v8 support. Includes the work from #1408.

Changes

What does this PR do?

Monkey patches getHeaders if it does not exist, and leaves it as is otherwise.

[retrohacker]

Reviewed by @yunong in #1408, merging once we have passing tests.

[kokarn]

Any chance of a patch release for this?

[kwhitley]

👍

Also waiting to push a release of https://www.npmjs.com/package/apicache as it's restify compatible and currently experiencing the infinite response loop in tests w Node 8.1.13 and restify v5 (also of note, v4 failed tests under Node v8 as well).

[retrohacker]

@kokarn @kwhitley just released 5.0.1 😄

[kokarn]

Thank you! Works great <3

…

On Tue, Jul 18, 2017, 03:03 William Blankenship ***@***.***> wrote: @kokarn <https://github.com/kokarn> @kwhitley <https://github.com/kwhitley> just released 5.0.1 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1409 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABT29FDJIc_KbY-Gct5UazkOXEY7u94Uks5sPAR7gaJpZM4OWDFq> .