fix: use close event on response instead of socket #1892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1880, we switched from using the close event on
req
to close onreq.socket
. This addressed the intended issue but can trigger frequentwarnings when keep-alive is used due to a listener being added for each
request on the same socket.
By using the close event on
res
instead, we address both the issue ofevent ordering in Node.js >= 16 that the original change was targeting
and the event emitter warning leak.
Fixes #1883.