Allow 0, false, and null as json body #686 #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0, false, and null are all valid body contents of a request, however currently only an empty body is returned in these cases. For Example: response.json(200, true); - currently returns: 200 OK true - however false doesn't return a body: response.json(200, false); 200 OK Change allows false to also return: response.json(200, false); 200 OK false
|
Hi, thanks so much for the PR. Could you please add a test case for this? Prefix the name with gh-800. |
|
+huge support |
yunong
added a commit
that referenced
this pull request
May 21, 2015
Allow 0, false, and null as json body #686
AlexDobeck
added a commit
to AlexDobeck/node-restify
that referenced
this pull request
Jun 9, 2015
… as json body)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0, false, and null are all valid body contents of a request, however currently only an empty body is returned in these cases.
For Example:
response.json(200, true);
200 OK
true
response.json(200, false);
200 OK
Change allows false to also return:
response.json(200, false);
200 OK
false