Skip to content

Conversation

@mjuen
Copy link
Contributor

@mjuen mjuen commented Jul 17, 2022

Description

  • Consider HTTP status code and ResponseStatus for IsSuccessful in RestResponseBase
  • Added IsSuccessStatusCode to RestResponseBase

Resolves #1892

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@mjuen mjuen changed the title Fix IsSuccessful in RestResponse (consider RequestStatus) Fix IsSuccessful in RestResponse (consider ResponseStatus) Jul 17, 2022
@alexeyzimarev alexeyzimarev merged commit 9e57655 into restsharp:dev Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IsSuccessful in RestResponse is true when deserialization fails

2 participants