Remove note that 404
response code means succes
#2281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looking into the documentation on handling responses, I found a note on
IsSuccessfulStatusCode
mentioning "that404
response code means succes". However, when checking implementation and tests, I found only thatResponseStatus
will beCompleted
on404
responses, butIsSuccessfulStatusCode
should befalse
.See also:
RestSharp/src/RestSharp/Options/RestClientOptions.cs
Lines 57 to 63 in 58180e8
RestSharp/test/RestSharp.Tests.Integrated/StatusCodeTests.cs
Lines 68 to 75 in 58180e8
Purpose
This pull request is a:
Checklist