Change AddDefaultParameter methods to be extension methods #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes implementing a custom IRestClient easier since these methods don't need to be reimplemented. They don't need access to any private methods or fields.
|
I'm fine with this change. It'll need a major version bump. |
|
Alright its in. Found it odd that there were merge issues for something this simple and noticed that your fork is ~7 mo behind. Rebase? Anyways, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AddDefaultParametermethods ofRestClientdon't need access to any private members or fields. They only need access to theDefaultParameterswhich is defined onIRestClient.By turning these into extension methods, the
IRestClientinterface is easier to implement and all implementations ofIRestClientget the benefit of these methods, not justRestClient.