Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse units correctly #42

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Parse units correctly #42

Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1afa386
Remove spaces in units
paul019 Apr 11, 2024
297e2b6
Detect percent as unit in console stringifier
paul019 Apr 11, 2024
f08047d
Add small lexer to parse units with per
paul019 Apr 11, 2024
f0cd95d
Fix consider-using-in
paul019 Apr 12, 2024
6d78fe2
Remove colons at the end of comments
paul019 Apr 21, 2024
4f731e6
Add separator to special degree symbol
paul019 Apr 21, 2024
8e7bb5e
Rename variable
paul019 Apr 21, 2024
497dfee
Split white spaces greedily
paul019 Apr 21, 2024
dbe18f1
Add 1/% unit to playground
Splines Aug 14, 2024
e9a0d82
Simplify if conditions in unit handling
Splines Aug 14, 2024
e237678
Add "only numerator units" to playground tests
Splines Aug 14, 2024
64b7d84
Remove all whitespace characters in unit string
Splines Aug 14, 2024
cf26dda
Add more unit tests to playground
Splines Aug 14, 2024
d1c1312
Merge branch 'main' into fix/parse-units
Splines Sep 11, 2024
6d90130
Strip whitespaces around parentheses
Splines Sep 11, 2024
9be9b27
Replace `per` by `/` in console
Splines Sep 11, 2024
772e86d
Add more examples for parentheses to playground
Splines Sep 11, 2024
01afd94
Add TODO note for docs (console output)
Splines Sep 11, 2024
41eda66
Fix anomalous backlash in string
Splines Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/api/console_stringifier.py
View file
Open in desktop
Splines marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ def _modify_unit(self, unit: str) -> str:
Returns the modified unit.
"""
unit = (
unit.replace(r"\squared", "^2")
unit.replace(" ", "")
.replace(r"\squared", "^2")
.replace(r"\cubed", "^3")
.replace("\\percent", "\\%")
paul019 marked this conversation as resolved.
Show resolved Hide resolved
.replace("\\per\\", "/")
.replace(r"\per", "/")
.replace("\\", " ")
Expand Down