Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmmq 170 feat: 이벤트 생성 페이지 UI 개발 #20

Merged
merged 22 commits into from
Nov 3, 2023

Conversation

backward99
Copy link
Contributor

@backward99 backward99 commented Oct 31, 2023

💻 스크린샷 (선택사항)

image
image

📃 PR 설명

이벤트 생성 페이지에 대한 UI를 개발했습니다.

📃 참고사항

해당 PR에서는 CreateEventPage 파일만 확인해 주시면 됩니다!

🔎 PR포인트 및 궁금한 점

@backward99 backward99 added 🌟 Feat 새로운 기능을 추가할 경우 🔒 작업중 아직 완성되지 않은 PR labels Oct 31, 2023
@backward99 backward99 self-assigned this Oct 31, 2023
@backward99 backward99 force-pushed the GMMQ-170-feat/create-event-page-ui branch from dca7517 to 0525d27 Compare October 31, 2023 08:22
@backward99 backward99 added 🔒 작업중 아직 완성되지 않은 PR and removed 🔒 작업중 아직 완성되지 않은 PR labels Oct 31, 2023
@backward99 backward99 force-pushed the GMMQ-170-feat/create-event-page-ui branch from 6647f2a to f5d2a1b Compare October 31, 2023 14:25
Copy link
Contributor

@khakhiD khakhiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인원 수 인풋에 제한없음은 적용하지 않으셨네요!
이 부분은 내일 또 더 얘기해보시죠. 디자인에 제한없음 체크박스가 있다보니 백엔드 분들도 아마 그걸 감안하고 API를 만들어주실 것 같아요.

FormInput 컴포넌트 뜯어 고치시고 생성 페이지도 다시 리팩토링하시느라 고생 많으셨습니다.
사이즈가 좀 큰 PR이다 보니 조금 더 얘기해봐요

import { Button } from '~/components/atoms/Button';
import FormLabel from '~/components/atoms/FormLabel/FormLabel';
import { FormControl } from '~/components/molecules/FormControl';
import FormDateInput from '~/components/molecules/FormDateInpur/FormDateInput';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FormDateInpur => FormDateInput 오타인가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 해당 부분은 form input PR에 올렸습니다..!

@backward99
Copy link
Contributor Author

지라에서 나눴던 대화내용 입니다 일단 저번에 이야기 나눴던 내용이 2~10명이라고 하는 것 같습니다..!

@backward99 backward99 force-pushed the GMMQ-170-feat/create-event-page-ui branch from 19fc8d5 to b8ff475 Compare November 1, 2023 07:46
@backward99 backward99 removed the 🔒 작업중 아직 완성되지 않은 PR label Nov 1, 2023
@backward99 backward99 force-pushed the GMMQ-170-feat/create-event-page-ui branch from 71f354a to 0a17b62 Compare November 1, 2023 23:58
Copy link
Member

@leeminhee119 leeminhee119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@backward99 backward99 force-pushed the GMMQ-170-feat/create-event-page-ui branch from 3e41842 to f788fe5 Compare November 3, 2023 00:36
@backward99 backward99 merged commit b92e0e9 into main Nov 3, 2023
1 check passed
@backward99 backward99 deleted the GMMQ-170-feat/create-event-page-ui branch November 3, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 Feat 새로운 기능을 추가할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants