Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mutate 함수 alias 변수명 통일 #267

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

leeminhee119
Copy link
Member

💻 스크린샷 (선택사항)

📃 PR 설명

  • 변수명을 method 접두사 + mutation 이름으로 통일했습니다.
  • useMutation 함수 파일에서는 useMutation 자체를 return하고, mutate 등은 사용하는 곳에서 디스트럭처링하도록 통일했습니다. (599ee79)
  • 모든 useMutation의 mutate함수는 alias를 사용하도록 통일했습니다.

📃 참고사항

🔎 PR포인트 및 궁금한 점

@leeminhee119 leeminhee119 added the 🛠 Refactor 리팩토링한 경우(리팩토링 과정에서 파일 삭제, 이동 포함) label Jan 10, 2024
@leeminhee119 leeminhee119 self-assigned this Jan 10, 2024
Copy link
Contributor

@backward99 backward99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다! 수고하셨습니다!

Comment on lines -41 to 43
const { mutate: patchCommentMutate } = usePatchFeedbackComment(resumeId, eventId);
const { mutate: deleteCommentMutate } = useDeleteFeedbackComment(resumeId, eventId);
const { mutate: patchComment } = usePatchFeedbackComment(resumeId, eventId);
const { mutate: deleteComment } = useDeleteFeedbackComment(resumeId, eventId);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 좋네요!

@@ -95,7 +95,7 @@ const ActivityDetails = ({
{isCurrentUser && (
<EditDeleteOptionsButton
onEdit={onEdit}
onDelete={() => deleteMutate({ resumeId, blockId })}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 이렇게 적힌게 있었군요

@leeminhee119 leeminhee119 merged commit 1fa08c5 into main Jan 11, 2024
1 check passed
@leeminhee119 leeminhee119 deleted the refactor/mutate branch January 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Refactor 리팩토링한 경우(리팩토링 과정에서 파일 삭제, 이동 포함)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants