style: 헤더 푸터, 이력서 작성 페이지 반응형 #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backward99
approved these changes
Mar 11, 2024
| @@ -20,6 +20,8 @@ const Footer = () => { | |||
| <Flex | |||
| w={'100%'} | |||
| mt={'3.14rem'} | |||
| wrap={'wrap'} | |||
There was a problem hiding this comment.
화면이 줄어들었을 때 넘친 컴포넌트를 다음으로 넘기기 위한 부분이군요!
Comment on lines
+88
to
+89
| columnGap={'3rem'} | ||
| rowGap={'1rem'} |
There was a problem hiding this comment.
wrap으로 넘어간 부분 간격을 따로 지정하기 위해서 구분하신거군요!
| 수여 기관 | ||
| </FormLabel> | ||
| <FormControl | ||
| w={'fit-content'} |
There was a problem hiding this comment.
FormControl에 w를 주신 이유가 있나요? FormLabel에 있을 때랑 어떤 차이가 있는지 궁금합니다!
There was a problem hiding this comment.
FormLabel에 주었을 때는 라벨 크기에 맞춰지고, FormControl에 주었을 때는 라벨 + 인풋까지 포함한 부모 element 사이즈에 맞춰집니다! FormLabel에는 디폴트 width를 부여하고 있는 것 같아 라벨 크기들을 웬만하면 통일시키려고 이렇게 수정했던 것 같아요
| gap={'3rem'} | ||
| columnGap={'3rem'} | ||
| rowGap={'1rem'} | ||
| justifyContent={'space-between'} |
There was a problem hiding this comment.
justifyContent={'space-between'}를 해도 columnGap={'3rem'} 부분이 잘 적용되나요?
There was a problem hiding this comment.
어엇 아뇨! columnGap은 제거해도 되겠네요! 반영하겠습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 스크린샷 (선택사항)
📃 PR 설명
📃 참고사항
🔎 PR포인트 및 궁금한 점