Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert STRUCT! definition in mmreg #278

Closed
wants to merge 1 commit into from
Closed

Revert STRUCT! definition in mmreg #278

wants to merge 1 commit into from

Conversation

mvdnes
Copy link

@mvdnes mvdnes commented Apr 17, 2016

WAVEFORMATEX and WAVEFORMATEXTENSIBLE need #[repr(C, packed)], see #202.

@mvdnes
Revert STRUCT! definition in mmreg
5818fcb 
WAVEFORMATEX and WAVEFORMATEXTENSIBLE need #[repr(C, packed)], see retep998#202.
@mvdnes
Copy link
Author

mvdnes commented Apr 27, 2016

Any update?
Although using rust-lang/rfcs#1399 would be better, I would like this merged in the meantime to fix a problem I am having.

@retep998
Copy link
Owner

I possibly have a better fix in a06b9bc

@mvdnes
Copy link
Author

mvdnes commented Apr 29, 2016

That works, and is a better solution 👍

@mvdnes mvdnes closed this Apr 29, 2016
@mvdnes mvdnes deleted the mmreg_packed branch April 29, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvdnes @retep998