Feature/implement issue 389 #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briemla
requested review from
diba1013,
a team and
beatngu13
and removed request for
diba1013 and
a team
rebazer
force-pushed
the
feature/implement-issue-389
branch
from
6ba6340
to
a664530
Compare
beatngu13
suggested changes
Feb 5, 2020
src/test/java/de/retest/web/selenium/css/RegexTransformerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/de/retest/web/selenium/css/PredicateBuilderTest.java
Outdated
Show resolved
Hide resolved
rebazer
force-pushed
the
feature/implement-issue-389
branch
2 times, most recently
from
367a5e1
to
14d5845
Compare
briemla
force-pushed
the
feature/implement-issue-389
branch
from
9e59c23
to
dc4a512
Compare
Implement all attribute selectors. Ensure attribute value is available. Create predicates for css selectors in separate class. Configure supported css selectors via regex expression and factory method. Support already available pseudo classes. Ignore not selector. Verify attribute selectors in integration test. Update changelog
rebazer
force-pushed
the
feature/implement-issue-389
branch
from
dc4a512
to
9c4be91
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
beatngu13
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submission, please check that ...
Description
This is a partial implementation of issue #389. It supports all attribute selectors specified at w3schools and the following pseudo class selectors:
:checked,:disabledand:read-onlyState of this PR
This PR does not support pseudo class selectors except
:checked,:disabledand:read-only.Additional Context