Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should use kryo.setRegistrationRequired( true ) #836

Open
martin-v opened this issue Mar 4, 2021 · 0 comments · Fixed by #838
Open

We should use kryo.setRegistrationRequired( true ) #836

martin-v opened this issue Mar 4, 2021 · 0 comments · Fixed by #838
Labels
bug Something isn't working good first issue Good for newcomers refactoring Restructure or improve existing code

Comments

@martin-v
Copy link
Member

martin-v commented Mar 4, 2021

It's since kryo 5 it's for good reasons the default to register classes, for more details see
EsotericSoftware/kryo#398

In KryoPersistence.java#81 remove the line and add registration for all used classes.
@martin-v martin-v added bug Something isn't working good first issue Good for newcomers refactoring Restructure or improve existing code labels Mar 4, 2021
martin-v added a commit that referenced this issue Mar 5, 2021
@martin-v
Start implementing kryo registration #836
d226fa9
@martin-v martin-v mentioned this issue Mar 5, 2021
Merged
6 tasks
rebazer pushed a commit that referenced this issue Mar 5, 2021
@martin-v
Start implementing kryo registration #836
a8d3f2e
martin-v added a commit that referenced this issue May 28, 2021
@martin-v
Start implementing kryo registration #836
4968ea6
rebazer pushed a commit that referenced this issue May 28, 2021
@martin-v
Start implementing kryo registration #836
0fa805d
@mergify mergify bot closed this as completed in #838 May 28, 2021
martin-v added a commit that referenced this issue Jun 1, 2021
@martin-v
Register more classes for kryo #836
88fb180
rebazer pushed a commit that referenced this issue Jun 1, 2021
@martin-v
Register more classes for kryo #836
d2f5955
@martin-v martin-v reopened this Jun 1, 2021
martin-v added a commit that referenced this issue Jun 25, 2021
@martin-v
Register more classes in kryo, see #836
b0da999
martin-v added a commit that referenced this issue Jun 25, 2021
@martin-v
Register more classes in kryo, see #836
9f012d4
rebazer pushed a commit that referenced this issue Jun 28, 2021
@martin-v
Register more classes in kryo, see #836
0b55098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers refactoring Restructure or improve existing code
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/update kryo retest/recheck
1 participant
@martin-v