Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot load Youtube iframe #604

Closed
fredele opened this issue Dec 16, 2022 · 1 comment
Closed

Cannot load Youtube iframe #604

fredele opened this issue Dec 16, 2022 · 1 comment

Comments

@fredele
Copy link

fredele commented Dec 16, 2022

When navigating on Youtube, you can copy an integration code which resembles to this :

<iframe width="837" height="614" src="https://www.youtube.com/embed/XXXXXXXXX" title="title" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>

At the current state, the frame is displayed but not the video.
This behavior is due to the function "acceptNavigationRequest" in the file "webenginepreview.py"

If you add to this function this statement :

if url.scheme() == "https":
            return True

the iframe is properly loaded and the video displayed ...

( ...and yes, I know, I should do a proper pull request ...)

@fredele fredele closed this as completed Dec 16, 2022
@mitya57
Copy link
Member

mitya57 commented Dec 18, 2022

Actually, I think we should fix this issue by allowing all requests when isMainFrame argument is False.

@mitya57 mitya57 reopened this Dec 18, 2022
mitya57 added a commit that referenced this issue May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants