-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expanded ellipses options #11
Conversation
- Adds 'unspaced' and 'spaced'
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 354 377 +23
=========================================
+ Hits 354 377 +23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience and thanks for your work!
This looks quite good!
I am not sure about the style names, and how the options are described. To me this reads as if the resulting ellipses are (un)spaced. I’m not sure what names I’d prefer, so here some suggestions on description.
Can you also put the new docs in the API section of the readme? Thanks!
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
@wooorm Thank you for reviewing! I think I've added in all the changes you asked for. Let me know how it looks. |
Initial checklist
Description of changes
Re: #9 discussion, this PR adds
'unspaced'
and'spaced'
options to ellipses config:true
, turns triple dots into ellipses (with or without spaces between);'unspaced'
, turns triple dots into ellipses (only for those without spaces);'spaced'
, turns triple dots into ellipses (only for those with spaces).