Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expanded ellipses options #11

Merged
merged 9 commits into from
Jan 13, 2024
Merged

Add expanded ellipses options #11

merged 9 commits into from
Jan 13, 2024

Conversation

teddybradford
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Re: #9 discussion, this PR adds 'unspaced' and 'spaced' options to ellipses config:

  • when true, turns triple dots into ellipses (with or without spaces between);
  • when 'unspaced', turns triple dots into ellipses (only for those without spaces);
  • when 'spaced', turns triple dots into ellipses (only for those with spaces).

- Adds 'unspaced' and 'spaced'
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Nov 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc33ba5) 100.00% compared to head (9d98f00) 100.00%.

❗ Current head 9d98f00 differs from pull request most recent head 79d7f19. Consider uploading reports for the commit 79d7f19 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          354       377   +23     
=========================================
+ Hits           354       377   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience and thanks for your work!

This looks quite good!

I am not sure about the style names, and how the options are described. To me this reads as if the resulting ellipses are (un)spaced. I’m not sure what names I’d prefer, so here some suggestions on description.

Can you also put the new docs in the API section of the readme? Thanks!

lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
teddybradford and others added 7 commits January 12, 2024 18:22
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
@teddybradford
Copy link
Contributor Author

@wooorm Thank you for reviewing! I think I've added in all the changes you asked for. Let me know how it looks.

@wooorm wooorm changed the title Expand ellipses options Add expanded ellipses options Jan 13, 2024
@wooorm wooorm merged commit 6fa9e37 into retextjs:main Jan 13, 2024
2 checks passed
@wooorm wooorm added the 💪 phase/solved Post is done label Jan 13, 2024

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 13, 2024
@wooorm
Copy link
Member

wooorm commented Jan 13, 2024

thanks, released! https://github.com/retextjs/retext-smartypants/releases/tag/6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

3 participants