Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 feat(retext-german): add new package for parsing German natural language #95

Closed
wants to merge 1 commit into from

Conversation

nyxb
Copy link

@nyxb nyxb commented Oct 5, 2023

Initial checklist

  • [ x] I read the support docs
  • [x ] I read the contributing guide
  • [ x] I agree to follow the code of conduct
  • [x ] I searched issues and couldn’t find anything (or linked relevant results below)
  • [x ] If applicable, I’ve added docs and tests

Description of changes

Hi I created this because I need it for a project and thought so you can extend the whole thing with a language. 😊

I also had to create a german-parser for it which I also just adapted from yours. I would also like to give you the repository if you want. you can find it here: https://github.com/nyxb/parse-german. It takes into account the german spelling as well as umlauts etc.

🔧 chore(retext-german): add .npmrc and tsconfig.json for package configuration

📝 docs(retext-german): add readme.md for package documentation

🎉 init(retext-german): create index.js and lib/index.js for initial package setup

🔧 chore(retext-german): add package.json for package metadata and dependencies

…guage

🔧 chore(retext-german): add .npmrc and tsconfig.json for package configuration

📝 docs(retext-german): add readme.md for package documentation

🎉 init(retext-german): create index.js and lib/index.js for initial package setup

🔧 chore(retext-german): add package.json for package metadata and dependencies
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Oct 5, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 5, 2023
@nyxb
Copy link
Author

nyxb commented Oct 5, 2023

Strange that the node tests do not run I do not have these errors locally.

image

i only see this one:

yarn run v1.22.19
$ npm run build && npm run format && npm run test-coverage

> build
> tsc --build --clean && tsc --build && type-coverage

test.js:135:14 - error TS2367: This comparison appears to be unintentional because the types '"SourceNode" | "WhiteSpaceNode" | "SymbolNode" | "PunctuationNode" | "WordNode"' and '"EmoticonNode"' have no overlap.

135       assert(emoji.type === 'EmoticonNode')
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@ChristianMurphy ChristianMurphy requested review from wooorm and a team October 6, 2023 00:46
@ChristianMurphy ChristianMurphy added the 🗄 area/interface This affects the public interface label Oct 6, 2023
@wooorm
Copy link
Member

wooorm commented Jan 12, 2024

Hi Dennis, thanks for your work and your patience!

I would also like to give you the repository if you want.

No, thank you. Seems like extra work that I cannot do (I am not a native german speakers), with no benefit: it’s open source, anyone can maintain anything.


It looks like you copy/pasted a folder in there. That’s a good start, but doesn’t make everything workable.
You need to add it as a workspace in the root package.json:

"workspaces": [
.
Then you run npm install and npm test and such from there.

You are also currently getting type errors. I assume because index.d.ts is not published in parse-german. Can you also at least publish a 0.1.0 there? That way, semver can work. At 0.0.1 semver does not work.

For your new package retext-german here, you can start with 0.0.0. I will do the publishing and update the versions for you.

Particularly the npm test I mentioned earlier is important to run: that formats everything. Looking at the readme, it’s not formatted according to this project’s style.

As for your error here: you are using yarn. Don’t use yarn, we use npm. From the root of the project run npm install and then npm test and such.

@nyxb
Copy link
Author

nyxb commented Jan 13, 2024

Ok will do it

@wooorm
Copy link
Member

wooorm commented Sep 19, 2024

Thanks for the PR. Closing for now as this cannot land currently and there seems to be no activity.

I recommend just publishing and maintaining this yourself! I don’t need to do all the work. It’s open source. Others can do work too!

@wooorm wooorm closed this Sep 19, 2024
@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label Sep 19, 2024

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 19, 2024
@wooorm wooorm removed the 🗄 area/interface This affects the public interface label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

3 participants