Skip to content

ZipFileSystemProvider backed classpath impl, to avoid ZipFile lock contention #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
728aed2
bump sbt to 1.3.13
griggt Feb 11, 2021
a1dcdcf
GitHub Actions: build and test on Windows
griggt Feb 11, 2021
6aed5b0
remove obsolete CI scripts
SethTisue Apr 21, 2021
5430edf
Merge pull request #9496 from griggt/wip/gh-actions-windows
SethTisue Apr 21, 2021
53d8e09
Add null check for getURLs-method
Philippus Apr 22, 2021
21b1850
GitHub Actions: Windows CI: align with Travis-CI, use simpler bootstrap
SethTisue Apr 21, 2021
2945fc4
Merge pull request #9585 from SethTisue/align-gha-with-travis
SethTisue Apr 22, 2021
0fbe2d5
Cache -Xsource comparisons in currentRun
adriaanm Apr 22, 2021
6dccef6
Add infrastructure for -Xsource:3 support
smarter Apr 22, 2021
02251e9
Support `case` in pattern bindings under -Xsource:3
smarter Mar 30, 2021
ff08013
Support `?` as wildcard marker under -Xsource:3
smarter Mar 31, 2021
4aba41f
Support Scala 3 wildcard and renaming imports under -Xsource:3
smarter Apr 19, 2021
d79e333
Support Scala 3 vararg splice syntax under -Xsource:3
smarter Apr 20, 2021
97ccdff
Allow soft keywords `open` and `infix` under -Xsource:3
smarter Apr 1, 2021
44a2b2f
Merge pull request #9589 from smarter/backport-scala3-syntax
lrytz Apr 23, 2021
8679754
Support writing `&` instead of `with` in types under `-Xsource:3`
smarter Apr 23, 2021
ee71182
Merge pull request #9588 from Philippus/issue-12376
dwijnand Apr 26, 2021
7e23749
Merge pull request #9595 from smarter/backport-and-syntax
lrytz Apr 27, 2021
493f985
Include --release version in cache key for classpath cache
retronym May 4, 2021
0714941
Cache JRT and --release (ct.sym) classpath elements.
retronym May 4, 2021
31255c3
Avoid contention in classpath access
retronym May 4, 2021
d0396cd
Adjust conversion of AbstractFile's name to TypeName
retronym May 4, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ text eol=lf
*.txt eol=lf
*.xml eol=lf

# Some sbt launcher scripts can't handle CR in .jvmopts
.jvmopts eol=lf

# Windows-specific files get windows endings
*.bat eol=crlf
*.cmd eol=crlf
Expand Down
47 changes: 47 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Scala Merge CI

on:
push:
branches: ['2.*.x']

defaults:
run:
shell: bash

jobs:
build_and_test:
name: Windows
runs-on: windows-latest
strategy:
fail-fast: false
steps:
- run: git config --global core.autocrlf false
- name: Checkout
uses: actions/checkout@v2

# Note that we don't use olafurpg/setup-scala; it wouldn't buy us anything
# over setup-java. (We don't want csbt or xsbt; we prefer the standard
# sbt launch script, which comes preinstalled on Windows (and Ubuntu).)
- name: Setup Java
uses: actions/setup-java@v2
with:
distribution: adopt
java-version: 8

- name: Cache
uses: actions/cache@v2
with:
path: |
~/.sbt
~/.ivy2/cache
~/.cache/coursier
key: ${{ runner.os }}-sbt-cache-v2-${{ hashFiles('**/*.sbt') }}-${{ hashFiles('project/build.properties') }}

- name: Build
run: |
sbt setupPublishCore generateBuildCharacterPropertiesFile headerCheck publishLocal

- name: Test
run: |
STARR=`cat buildcharacter.properties | grep ^maven.version.number | cut -d= -f2` && echo $STARR
sbt -Dstarr.version=$STARR setupValidateTest test:compile info testAll
5 changes: 5 additions & 0 deletions project/MimaFilters.scala
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ object MimaFilters extends AutoPlugin {

// #9166 add missing serialVersionUID
ProblemFilters.exclude[MissingFieldProblem]("*.serialVersionUID"),

// private[scala] Internal API
ProblemFilters.exclude[IncompatibleMethTypeProblem]("scala.reflect.io.FileZipArchive#LeakyEntry.this"),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("scala.reflect.io.FileZipArchive#LeakyEntry.this"),
ProblemFilters.exclude[MissingClassProblem]("scala.reflect.io.FileZipArchive$zipFilePool$"),
)

override val buildSettings = Seq(
Expand Down
2 changes: 1 addition & 1 deletion project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.3.8
sbt.version=1.3.13
2 changes: 1 addition & 1 deletion scripts/common
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ rm -rf "$WORKSPACE/resolutionScratch_"
mkdir -p "$WORKSPACE/resolutionScratch_"

SBT_CMD=${SBT_CMD-sbt}
SBT_CMD="$SBT_CMD -sbt-version 1.3.8"
SBT_CMD="$SBT_CMD -sbt-version 1.3.13"

# repo to publish builds
integrationRepoUrl=${integrationRepoUrl-"https://scala-ci.typesafe.com/artifactory/scala-integration/"}
Expand Down
35 changes: 0 additions & 35 deletions scripts/jobs/integrate/ide

This file was deleted.

22 changes: 0 additions & 22 deletions scripts/jobs/integrate/windows

This file was deleted.

6 changes: 6 additions & 0 deletions src/compiler/scala/tools/nsc/Global.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1142,6 +1142,12 @@ class Global(var currentSettings: Settings, reporter0: Reporter)
val profiler: Profiler = Profiler(settings)
keepPhaseStack = settings.log.isSetByUser

// We hit these checks regularly. They shouldn't change inside the same run, so cache the comparisons here.
val isScala211: Boolean = settings.isScala211
val isScala212: Boolean = settings.isScala212
val isScala213: Boolean = settings.isScala213
val isScala3: Boolean = settings.isScala3

// used in sbt
def uncheckedWarnings: List[(Position, String)] = reporting.uncheckedWarnings
// used in sbt
Expand Down
Loading