Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: convert more test skips to known failures #179

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Sep 30, 2024

Some of the tests previously being skipped could be run under cargo nextest in our compat test harness's "pty mode" instead. Some still fail, but at least they can be run and show up as known failures.

@reubeno reubeno enabled auto-merge (squash) September 30, 2024 04:44
@reubeno reubeno merged commit ee0b8e3 into main Sep 30, 2024
10 checks passed
@reubeno reubeno deleted the fewer-test-skips branch September 30, 2024 04:50
Copy link

Test Results

  2 files    8 suites   53s ⏱️
423 tests 423 ✅ 0 💤 0 ❌
846 runs  846 ✅ 0 💤 0 ❌

Results for commit e6a7b11.

Copy link

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.36 μs 3.36 μs 0.00 μs ⚪ Unchanged
instantiate_shell 59.23 μs 59.40 μs 0.16 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 24958.27 μs 24998.94 μs 40.67 μs ⚪ Unchanged
parse_bash_completion 5694.14 μs 5706.17 μs 12.04 μs ⚪ Unchanged
parse_sample_script 9.04 μs 8.98 μs -0.06 μs ⚪ Unchanged
run_echo_builtin_command 92.06 μs 91.99 μs -0.07 μs ⚪ Unchanged
run_one_builtin_command 111.10 μs 114.18 μs 3.08 μs 🟠 +2.77%
run_one_external_command 1863.63 μs 1951.72 μs 88.09 μs 🟠 +4.73%
run_one_external_command_directly 949.59 μs 952.06 μs 2.46 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/shell.rs 🟢 77.22% 🟢 77.83% 🟢 0.61%
brush-core/src/sys/unix/signal.rs 🟠 67.65% 🟠 64.71% 🔴 -2.94%
brush-shell/src/args.rs 🟠 64.29% 🟠 66.67% 🟢 2.38%
brush-shell/src/main.rs 🟢 91.43% 🟢 92.86% 🟢 1.43%
Overall Coverage 🟢 76.09% 🟢 76.13% 🟢 0.04%

Minimum allowed coverage is 70%, this run produced 76.13%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant