Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: try to run interactive tests with Alacritty #250

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

39555
Copy link
Contributor

@39555 39555 commented Oct 27, 2024

WIP. I've connected expectrl to the Alacritty terminal. It can run any command with reedline backend, for example the test run_pipeline_interactively, but the command output is somehow messed up with OSC sequences and prompts, so precise control how it is done in Session::exec_output("jobs") is not possible for now

@39555 39555 marked this pull request as draft October 27, 2024 11:47
Copy link

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.41 μs 3.41 μs 0.00 μs ⚪ Unchanged
instantiate_shell 60.40 μs 60.32 μs -0.08 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 30484.21 μs 30795.66 μs 311.45 μs ⚪ Unchanged
parse_bash_completion 2820.39 μs 2817.26 μs -3.13 μs ⚪ Unchanged
parse_sample_script 4.22 μs 4.33 μs 0.11 μs 🟠 +2.68%
run_echo_builtin_command 89.21 μs 90.87 μs 1.66 μs 🟠 +1.86%
run_one_builtin_command 107.98 μs 109.51 μs 1.53 μs ⚪ Unchanged
run_one_external_command 1962.60 μs 1960.88 μs -1.71 μs ⚪ Unchanged
run_one_external_command_directly 1007.28 μs 1004.12 μs -3.15 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/shell.rs 🟢 77.73% 🟢 77.87% 🟢 0.14%
Overall Coverage 🟢 73.79% 🟢 73.8% 🟢 0.01%

Minimum allowed coverage is 70%, this run produced `73.8%``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant