Support no encryption and escape SSID and password data #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background information for these changes can be found on ZXing's Wi-Fi Network config documentation section which is also referenced from the Wikipedia page and section on wifi networks.
No Encryption
No WiFi encryption is now supported. This is enabled on the command line with the
-encoption which can be set toNONE,NOPASS, or empty with-enc ""and the user will not be prompted for a password. In the case where an invalid protocol is specified, the selection list now includes aNONEoption after which the user is not prompted for a password. As before, the encryption protocol defaults to WPA2.Escape of SSID and Password
Special characters in the SSID and password are now escaped with backslashes (
\).Increased Unit Testing
Unit tests have been added to support some of the new functionality, for building the string used to generate the QR code (
buildSchema) and a few other functions.