Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support i18nMonth for date in list item #235

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hucste
Copy link
Contributor

@hucste hucste commented Aug 5, 2020

if i18n exists, the month into this list item is not correctly displayed. Actually, only in english.
With this fixe, month is displayed segun language code.

@reuixiy
Copy link
Owner

reuixiy commented Aug 8, 2020

So as the comment in config.toml,

# Translate the month? (valid for title)
i18nMonth = false

I don't think this is a bug. Though, it could be an enhancement.

Also, in your code, if i18nMonth is enabled, then the listDateFormat will not be respected -- it's hard-coded to "January 2" format. But there are many different date formats in different countries, see:

In other words, the character is i18ned but the format is not, or is destroyed.

@reuixiy reuixiy changed the title Fix: display correctly month if languageCode ne EN feat: support i18nMonth for date in list item Aug 8, 2020
@hucste
Copy link
Contributor Author

hucste commented Aug 8, 2020

Ok, I understand the problem. For the moment, I don't known how fix it.
but you have to admit that having the dates, once in FR (or other lang), once in EN, so sucks. :(
(I thought I'd come up with a solution and move things along...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants