Migrate Item details to Direct2D #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reupen
force-pushed
the
item-details-d2d
branch
4 times, most recently
from
99d4208 to
d0b1a85
Compare
This migrates Item details from GDI to Direct2D. Text rendering appears to be identical in all modes. This also adds support for SVG glyphs, in theory from later Windows 10 versions onwards (but I'm only aware of Windows 11 actually having SVG glyphs in Segoe UI Emoji).
This fixes a small bug in Item details where left and top padding where missing when there was no horizontal and vertical scroll bar respectively.
This fixes a small bug where `%default_font_face%` (deprecated) and `%default_font_size%` did not update in Item details until some other event triggered a content update.
reupen
force-pushed
the
item-details-d2d
branch
from
874a78c to
7f096e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#954
This migrates Item details from GDI to Direct2D. Text rendering appears to be identical in all modes.
This also adds support for SVG glyphs, in theory from later Windows 10 versions onwards (but I'm only aware of Windows 11 actually having SVG glyphs in Segoe UI Emoji).
Additionally, a couple of small bugs with padding and font-related title formatting fields were fixed.