Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages: merge the sig messages to the WT into a single sigs #115

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

darosior
Copy link
Member

Fixes #109, closes #98.

darosior added a commit to darosior/miradord that referenced this pull request Jan 24, 2022
This adapts (and greatly simplifies) the implementation to the update of
the `sig` message: revault/practical-revault#115.

There is no concept of 'delegated' vaults anymore, we now watch the
chain for all of them. This is in preparation of getting rid of dynamic
fee bumping..
darosior added a commit to darosior/revault_net that referenced this pull request Jan 24, 2022
darosior added a commit to revault/revault_net that referenced this pull request Jan 24, 2022
c1febc9 messages: batch revocation txs sigs exchange with the WT (Antoine Poinsot)

Pull request description:

  As per revault/practical-revault#115

ACKs for top commit:
  darosior:
    ACK c1febc9 -- tested downstream using `revaultd`'s and `miradord`'s test suites.

Tree-SHA512: 558c777099aa366cc1ea6465cdc4485c03b33e3ef54b9960ca165b7c06d4ceea44f8639f016a9d152396f1c55af5c6ce02fad03c77a5e828d220b77b4108adb3
darosior added a commit to darosior/miradord that referenced this pull request Jan 24, 2022
This adapts (and greatly simplifies) the implementation to the update of
the `sig` message: revault/practical-revault#115.

There is no concept of 'delegated' vaults anymore, we now watch the
chain for all of them. This is in preparation of getting rid of dynamic
fee bumping..
darosior added a commit to revault/miradord that referenced this pull request Jan 24, 2022
c1f44de poller: panic, don't error on invalid signatures (Antoine Poinsot)
4a38d3d listener: merge the revocation signatures in a single message (Antoine Poinsot)

Pull request description:

  This implements revault/practical-revault#115.
  Needs revault/revault_net#78 upstream.

ACKs for top commit:
  darosior:
    ACK c1f44de -- tested using `revaultd`'s test suite.

Tree-SHA512: 03ede169ce96c1b0ae6e26e43ca6ec88683c0a60951eb5523c7e7f28c970d4ae12aa57dd205334d6f294bf2d996dfb5e5b50c9602b8c4f7cbf981f6589b6bed9
Copy link
Member Author

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f96ef9e

This was implemented and tested downstream.

darosior added a commit to revault/revaultd that referenced this pull request Jan 25, 2022
003a308 ci: remove most of the cache across runs (Antoine Poinsot)
67f4fc2 tests/servers: update miradord to latest master (Antoine Poinsot)
662a1bb commands, sigfetcher: batch the rev signatures exchange with watchtowers (Antoine Poinsot)

Pull request description:

  As per revault/practical-revault#115.
  This greatly simplifies the implementation, too!

ACKs for top commit:
  darosior:
    self-ACK 003a308

Tree-SHA512: 96351256bd06775498133d28ec68527f7e724378e2f0c3c4c8a044f47d3429a44c5291ba8bf31cdbcc28f2a1fca51e1d8420919be9b3c853298beea573237466
@darosior darosior merged commit 0c230ca into revault:master Jan 25, 2022
@darosior darosior deleted the merge_wt_sigs branch January 25, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant