Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wording at Spend broadcast #281

Closed
darosior opened this issue Dec 15, 2021 · 0 comments · Fixed by #294
Closed

Wording at Spend broadcast #281

darosior opened this issue Dec 15, 2021 · 0 comments · Fixed by #294
Labels
Wording
Milestone
Third demo: huffl...

Comments

@darosior
Copy link
Member

i think a better wording here would be "Transaction is fully signed". Then the button would only be labeled with action it performs: "Broadcast". I think answering the question is weird.
image
@darosior darosior added this to the Third demo: huffle puffer milestone Dec 16, 2021
@darosior darosior mentioned this issue Dec 16, 2021
Open
@edouardparis edouardparis mentioned this issue Dec 16, 2021
Merged
edouardparis added a commit that referenced this issue Dec 16, 2021
@edouardparis
Merge #294: fix wording in spend tx broadcast view
9c02900 
9ad507a fix wording in spend tx broadcast view (edouard)

Pull request description:

  close #281

ACKs for top commit:
  danielabrozzoni:
    utACK 9ad507a

Tree-SHA512: bbc0f9ccf596edbea97a873fd156250056f060190f710afa5ff15c8997982e68220e614e0bfec56ef5bc24ce4a10a7ba17cb3199a5d1e4a89af62306172c2677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Wording
Projects
None yet
Milestone
Third demo: huffle puffer
Development

Successfully merging a pull request may close this issue.

fix wording in spend tx broadcast view edouardparis/revault-gui
1 participant
@darosior