Update to latest coordinatord to fix the storing bug #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielabrozzoni
force-pushed
the
20220207_coord_storing_bug
branch
3 times, most recently
from
4b64b96
to
d9a7ed5
Compare
|
Alright, one last re-run and this is good to go :) |
darosior
added a commit
to revault/coordinatord
that referenced
this pull request
Feb 8, 2022
b5d7cb5 Fix storing bug (Daniela Brozzoni) Pull request description: This bug would sometimes appear in the revaultd functional tests. The problem was that we would check if the signature was in the db, then if it wasn't there, try to insert it. The problem with this is that between the check and the insertion someone else might have inserted the signature. Here we remove the second check altoghether, and recognize if there were any duplicates from the eventual error at insertion. ACKs for top commit: darosior: This looks good to me, and seems to make CI happy in revault/revaultd#365. utACK b5d7cb5. Tree-SHA512: 86b4b90b70c4281c525cfc4675a92770a8211f4132109b52473dda299fa4755b6e5e2d0cba00d452e90ba515ee5c63d63c9731ec99028ecc762d17e8e8d7a4fe
danielabrozzoni
force-pushed
the
20220207_coord_storing_bug
branch
from
d9a7ed5
to
30e3e08
Compare
|
Ouch. |
|
Closing in favor of #361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs revault/coordinatord#47